Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Issues pattern to a block template #988

Merged

Conversation

GP-Dan-Tovbein
Copy link
Contributor

@GP-Dan-Tovbein GP-Dan-Tovbein commented Dec 26, 2022

Ref: PLANET-6942

Description

  • Converted the issues pattern to a block template
  • Replaced the core/media-text to core/image which works better with media sizes (width, height). The core/media-text works with % and it's difficult to follow exactly the UI.

Demo page

@GP-Dan-Tovbein GP-Dan-Tovbein self-assigned this Dec 26, 2022
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Dec 26, 2022
/unhold 64129a46-37a1-40af-9f5c-08b8f84050e5
@planet-4
Copy link
Contributor

planet-4 commented Dec 26, 2022

Test instance is ready 🚀

🌑 rhea | admin | blocks report | CircleCI | composer-local.json

⌚ 2023.01.16 16:42:03

@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from 7819605 to fb845c7 Compare December 27, 2022 12:12
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Dec 27, 2022
/unhold d2c65d23-a5aa-4d90-afeb-318d8b183d0e
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Dec 27, 2022
/unhold ff182318-6aba-4df3-8850-d1c5c1244609
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from fb845c7 to fb16576 Compare January 13, 2023 20:15
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 13, 2023
/unhold 01ad417e-089d-4dce-bf56-868001cccc71
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from fb16576 to 4bab8ea Compare January 13, 2023 20:28
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 13, 2023
/unhold 0233d7db-4f9b-4f35-80ed-3ce0cfcca16f
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from 4bab8ea to e3e7563 Compare January 13, 2023 20:54
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 13, 2023
/unhold 92d57fed-5732-46b4-8638-aad22820c362
- New class for square images
- Force to use square images when the square class is added
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from e3e7563 to 5ba2ac6 Compare January 13, 2023 21:10
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 13, 2023
/unhold 791777c4-f325-44ee-b23e-7a909342c91a
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 16, 2023
/unhold 87dacfdc-8423-4cb2-8a7e-cd5a63958a26
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from 73f8702 to 3c7360f Compare January 16, 2023 16:33
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 16, 2023
/unhold cf14a77b-5b83-4fb7-b447-bd629e09b26c
- Font size family from px to rem, among other things
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6942_convert-issues-pattern-to-block-template branch from 3c7360f to 1c49630 Compare January 16, 2023 16:35
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jan 16, 2023
/unhold 3c034f42-b1d6-440e-9445-ca343d879523
Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, looks good to me 👍

@GP-Dan-Tovbein GP-Dan-Tovbein merged commit c40f244 into main Jan 16, 2023
@GP-Dan-Tovbein GP-Dan-Tovbein deleted the PLANET-6942_convert-issues-pattern-to-block-template branch January 16, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants